Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiComboBox] Added loading icon to combobox input #4015

Merged
merged 5 commits into from
Sep 8, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Adding more paddings exceptions
elizabetdev committed Sep 8, 2020
commit cce33990dd3b76ac34ce98f995e9323ed608463c
16 changes: 14 additions & 2 deletions src/components/combo_box/_combo_box.scss
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@

/**
* 1. Allow pills to truncate their text with an ellipsis.
* 2. Don't allow pills to overlap with the caret or clear button.
* 2. Don't allow pills to overlap with the caret, loading icon or clear button.
* 3. The height on combo can be larger than normal text inputs.
*/

@@ -50,7 +50,11 @@
}

&.euiComboBox__inputWrap-isLoading {
@include euiFormControlLayoutPadding(3);
@include euiFormControlLayoutPadding(2); /* 2 */
}

&.euiComboBox__inputWrap-isLoading.euiComboBox__inputWrap-isClearable {
@include euiFormControlLayoutPadding(3); /* 2 */
}
}

@@ -114,6 +118,14 @@
&.euiComboBox__inputWrap-isClearable {
@include euiFormControlLayoutPadding(2, $compressed: true); /* 2 */
}

&.euiComboBox__inputWrap-isLoading {
@include euiFormControlLayoutPadding(2, $compressed: true); /* 2 */
}

&.euiComboBox__inputWrap-isLoading.euiComboBox__inputWrap-isClearable {
@include euiFormControlLayoutPadding(3, $compressed: true); /* 2 */
}
}
}
}