Fix incorrect variable usage in SCSS #3991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3991/ |
snide
approved these changes
Sep 2, 2020
|
dope, thanks @snide, updated. I keep forgetting it :( |
cchaos
reviewed
Sep 2, 2020
CHANGELOG.md
Outdated
| @@ -10,6 +10,7 @@ | |||
| - Fixed type mismatch between `EuiSelectable` options extended via `EuiSelectableOption` and internal option types ([#3983](https://github.com/elastic/eui/pull/3983)) | |||
| - Fixed `EuiButton` CSS for RTL languages by using `margin-inline-[pos]` instead of `margin-[pos]` ([#3974](https://github.com/elastic/eui/pull/3974)) | |||
| - Fix server-side rendering of `EuiBreadcrumbs` and `EuiCollapsibleNav` ([#3970](https://github.com/elastic/eui/pull/3970)) | |||
| - Fix incorrect `euiCodeBlockNameColor` variable usage for `.hljs-name` in SCSS ([#3991](https://github.com/elastic/eui/pull/3991)) | |||
There was a problem hiding this comment.
Because there was a release after you made this PR, your Changelog needs to be in the master section above.
There was a problem hiding this comment.
I suspect changelog file doesn't like me... Or i need another cup of coffee... or both.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3991/ |
cjcenizal
approved these changes
Sep 2, 2020
cchaos
reviewed
Sep 2, 2020
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3991/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix incorrect variable usage in SCSS. Not sure how it got compiled.
Checklist