Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major version dependency upgrades, pt. I #3987

Merged
merged 7 commits into from
Sep 8, 2020

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Sep 1, 2020

Summary

Partial resolution of #3969: major version upgrades of devDependencies likely to not have material impact on production build assets.

Will wait for #3967 to merge before attempting to dedupe yarn.lock

Checklist

- [ ] Check against all themes for compatibility in both light and dark modes
- [ ] Checked in mobile
- [ ] Checked in Chrome, Safari, Edge, and Firefox
- [ ] Props have proper autodocs
- [ ] Added documentation
- [ ] Checked Code Sandbox works for the any docs examples
- [ ] Added or updated jest tests

  • Checked for breaking changes and labeled appropriately

- [ ] Checked for accessibility including keyboard-only and screenreader modes
- [ ] A changelog entry exists and is marked appropriately

@thompsongl thompsongl added the dependencies Pull requests that update a dependency file label Sep 1, 2020
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3987/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3987/

@thompsongl thompsongl marked this pull request as ready for review September 2, 2020 19:56
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! did not run release script locally but that'll be exercised soon enough; ran yo-component and verified the output

@thompsongl thompsongl merged commit a3ff1d9 into elastic:master Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants