Update and expand use of EuiSelectable option type generic #3983
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3966, where the addition of a generic extension of
EuiSelectableOption
needed to be further propagated to all aspects ofEuiSelectable
and related components. More types and components accept a generic (defaulted to{}
).To aid TypeScript parsing, the
id
prop was more explicitly restricted (never
instead ofOmit
, which could have been reinstated with the new generic).Tested in Kibana with expected updates flagged
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in Chrome, Safari, Edge, and Firefox- [ ] Checked Code Sandbox works for the any docs examples