Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Updated form guidelines with friendly spellcheck #3937

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

Jastor11
Copy link
Contributor

Summary

Provide a detailed summary of your PR. Explain how you arrived at your solution. If it includes changes to UI elements include a screenshot or gif.

Screen Shot 2020-08-18 at 12 00 08 PM

Changed charaters to characters in the form guidelines.

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs
  • Added documentation
  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Aug 18, 2020

💚 CLA has been signed

@cchaos
Copy link
Contributor

cchaos commented Aug 18, 2020

Welcome @Jastor11 ! Thanks for your PR.
Would you please sign the CLA linked below. Be sure to use the same email address linked to your Github account.
I'll get our CI (Jenkins, test this) started for you which will run our tests and get a preview built.
You won't need to add a Changelog entry since this only affects the docs site.

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3937/

@Jastor11
Copy link
Contributor Author

Just signed. Let me know if there's anything else you need.

@cchaos cchaos changed the title Updated guidelines.js with friendly spellcheck [Docs] Updated form guidelines with friendly spellcheck Aug 18, 2020
@cchaos cchaos added the documentation Issues or PRs that only affect documentation - will not need changelog entries label Aug 18, 2020
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, thx!

@cchaos cchaos merged commit 15df791 into elastic:master Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants