Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed prop not displaying for EuiExpression #3929

Merged
merged 1 commit into from
Aug 17, 2020
Merged

Fixed prop not displaying for EuiExpression #3929

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/components/expression/expression.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import React, {
HTMLAttributes,
MouseEventHandler,
ReactNode,
FunctionComponent,
} from 'react';
import classNames from 'classnames';
import { CommonProps, keysOf, ExclusiveUnion } from '../common';
Expand Down Expand Up @@ -99,13 +100,14 @@ export type EuiExpressionProps = CommonProps & {
};

type Buttonlike = EuiExpressionProps &
ButtonHTMLAttributes<HTMLButtonElement> & {
Omit<ButtonHTMLAttributes<HTMLButtonElement>, 'value'> & {
onClick: MouseEventHandler<HTMLButtonElement>;
};

type Spanlike = EuiExpressionProps & HTMLAttributes<HTMLSpanElement>;
type Spanlike = EuiExpressionProps &
Omit<HTMLAttributes<HTMLSpanElement>, 'value'>;

export const EuiExpression: React.FunctionComponent<ExclusiveUnion<
export const EuiExpression: FunctionComponent<ExclusiveUnion<
Buttonlike,
Spanlike
>> = ({
Expand Down