Support operator in field_value_selection filters #3922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3922/ |
|
jenkins test this |
Additionally adds a an operator example to the search bar demo, and use `OperatorType` in all other filters TS declaration. closes: elastic#3920
nyurik
force-pushed
the
nyurik/field-value-operator
branch
from
45a2112 to
2da1a58
Compare
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3922/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3922/ |
chandlerprall
approved these changes
Aug 25, 2020
There was a problem hiding this comment.
Changes LGTM; I merged master and added a changelog entry, will merge when CI passes
Thanks @nyurik !
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3922/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support operator in field_value_selection filters.
Additionally adds a an operator example to the search bar demo,
and use
OperatorTypein all other filters TS declaration.closes: #3920
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in Chrome, Safari, Edge, and Firefox- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples- [ ] Added or updated jest tests- [ ] Checked for accessibility including keyboard-only and screenreader modes