Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiToggle] Fix onChange prop type override #3921

Merged
merged 1 commit into from
Aug 14, 2020
Merged

[EuiToggle] Fix onChange prop type override #3921

merged 1 commit into from
Aug 14, 2020

Conversation

thompsongl
Copy link
Contributor

Summary

The div.onChange prop needs to be properly removed before the override onChange can get picked up by the docgen script.

### Checklist

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3921/

chandlerprall
chandlerprall approved these changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! 🦑

@thompsongl thompsongl merged commit cece6ad into elastic:master Aug 14, 2020
nyurik pushed a commit that referenced this pull request Aug 18, 2020
@thompsongl @nyurik
fix onChange type override (#3921)
2d46c10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thompsongl @kibanamachine @chandlerprall