Updated PR template to include all supported browsers #3861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3861/ |
myasonik
reviewed
Aug 4, 2020
| @@ -6,7 +6,7 @@ Provide a detailed summary of your PR. Explain how you arrived at your solution. | |||
|
|
|||
| - [ ] Check against **all themes** for compatibility in both light and dark modes | |||
| - [ ] Checked in **mobile** | |||
There was a problem hiding this comment.
Are there specific mobile browsers we're supposed to test in?
There was a problem hiding this comment.
I don't think we've ever discussed it to that level. This has been more of a quick validation that layouts aren't broken, in whatever device/browser you have available.
There was a problem hiding this comment.
Yeah here mobile = small screen sizes (for now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated the pull request template to include Chrome, Safari, Edge, and FF
### Checklist