Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding App Search and Workplace Search icons. #3859

Merged
merged 3 commits into from
Aug 5, 2020

Conversation

daveyholler
Copy link
Contributor

Summary

Adds app icons for App Search and Workplace Search

Workplace Search

image
image

App Search

image
image

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
    - [ ] Added documentation
    - [ ] Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@daveyholler daveyholler requested review from chandlerprall and cchaos and removed request for chandlerprall August 4, 2020 16:28
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3859/

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM! Fixed a CL conflict for ya. So once it passes CI again, good to merge.

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3859/

@daveyholler daveyholler merged commit a24201c into elastic:master Aug 5, 2020
nyurik pushed a commit that referenced this pull request Aug 18, 2020
* Adding App Search and Workplace Search icons.

* CL

Co-authored-by: Caroline Horn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants