-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slimmer pagination look / feel #380
Conversation
looks great.... how does it look like when there are 20 pages and you're now at page 10? Also, it would be nice if you can pass in a |
@uboness Good idea on the small one. Should be able to make that happen pretty easily. |
@cchaos that works for me. I can make that change. If you have a minute, feel free to review the code as well. There's not much to this PR so it should be fine, but I think I'm gonna merge it (before doing the ref changes) and then do that stuff in a followup PR. |
3f93e10
to
be975e7
Compare
@cchaos Good spot, fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
A slimmer pagination style requested by nearly everyone. cc @uboness
TODO
Make a full react component and use refs to properly assign focus state so we don't have the weird jumping with large pagination sets.Will do in later PR.