-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump prettier to 1.19.1 #3762
Bump prettier to 1.19.1 #3762
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @sulemanof
I'm good with these changes, but I'd like to have Chandler take a look as well. He'll be back next week.
Some of the changes are arbitrarily better, some are worse (all IMO, which is the point of prettier :-D ), so sure. :) Would you also update package.json to directly target 1.19, in addition to the yarn.lock update? |
Done |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3762/ |
flaky test jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3762/ |
Because this has a strong possibility to affect other "unrelated" files, I am going to call it out in tomorrow's team sync and update against master again before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, will merge on passing CI
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3762/ |
Summary
This bumps
prettier
to1.19.1
to accept bug fixes and features released.The initial request of it is to be to be consistent with
typescript ^3.7.0
, to use features likeOptional chaining
&Nullish coalescing
operators and otherChecklist