Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump prettier to 1.19.1 #3762

Merged
merged 6 commits into from
Jul 28, 2020
Merged

Conversation

sulemanof
Copy link
Contributor

@sulemanof sulemanof commented Jul 17, 2020

Summary

This bumps prettier to 1.19.1 to accept bug fixes and features released.
The initial request of it is to be to be consistent with typescript ^3.7.0, to use features like Optional chaining & Nullish coalescing operators and other

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation
  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @sulemanof

I'm good with these changes, but I'd like to have Chandler take a look as well. He'll be back next week.

@chandlerprall
Copy link
Contributor

Some of the changes are arbitrarily better, some are worse (all IMO, which is the point of prettier :-D ), so sure. :)

Would you also update package.json to directly target 1.19, in addition to the yarn.lock update?

@sulemanof
Copy link
Contributor Author

Some of the changes are arbitrarily better, some are worse (all IMO, which is the point of prettier :-D ), so sure. :)

Would you also update package.json to directly target 1.19, in addition to the yarn.lock update?

Done

@chandlerprall
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3762/

@chandlerprall
Copy link
Contributor

flaky test

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3762/

@chandlerprall
Copy link
Contributor

chandlerprall commented Jul 27, 2020

Because this has a strong possibility to affect other "unrelated" files, I am going to call it out in tomorrow's team sync and update against master again before merging.

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, will merge on passing CI

@chandlerprall
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3762/

@chandlerprall chandlerprall merged commit 43ccf53 into elastic:master Jul 28, 2020
@sulemanof sulemanof deleted the bump_prettier branch July 29, 2020 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants