Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute EuiComboBox's listbox zIndex #3551

Merged
merged 5 commits into from
Jun 10, 2020
Merged

Compute EuiComboBox's listbox zIndex #3551

merged 5 commits into from
Jun 10, 2020

Conversation

chandlerprall
Copy link
Contributor

@chandlerprall chandlerprall commented Jun 4, 2020 •
edited
Loading

Summary

Fixes an issue reported by @Kerry350 where a flyout>expression>popover>combobox's options list is rendered under the popover.

  • call getElementZIndex from popover_positioning service to find the target zIndex when opening the listbox
  • added example to the More complicated flyout section
  • removed $euiZComboBox scss variable

Before

broken zindex stacking

After

proper zindex stacking

Checklist

- [ ] Check against all themes for compatibility in both light and dark modes

  • Checked in mobile
  • Checked in IE11 and Firefox
    - [ ] Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@chandlerprall chandlerprall requested review from snide and cchaos June 4, 2020 15:55
cchaos
cchaos suggested changes Jun 4, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
src/components/combo_box/__snapshots__/combo_box.test.tsx.snap Outdated Show resolved Hide resolved
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3551/

@Kerry350 Kerry350 mentioned this pull request Jun 5, 2020
Merged
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3551/

@chandlerprall chandlerprall requested a review from cchaos June 5, 2020 19:52
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3551/

cchaos
cchaos approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. I can think of any degradations at the moment, so 🤞

snide
snide approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in browser and can't think of any problems this could cause.

@chandlerprall
Copy link
Contributor Author

jenkins test this?

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3551/

@chandlerprall chandlerprall merged commit 49deebb into elastic:master Jun 10, 2020
@chandlerprall chandlerprall deleted the bug/combobox-listbox-zindex branch June 10, 2020 21:04
phyolim pushed a commit to phyolim/eui that referenced this pull request Jun 11, 2020
@chandlerprall @phyolim
Compute EuiComboBox's listbox zIndex (elastic#3551)
e521e15 
* Updated EuiComboBox to match its combobox zIndex when rendering the listbox

* changelog

* Removed , now programmatically determining combobox options list zindex
@thompsongl thompsongl mentioned this pull request Jun 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

@snide snide snide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chandlerprall @kibanamachine @snide @cchaos