Add popoverPlacement prop in EuiDatePicker #3359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchaos
reviewed
Apr 20, 2020
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3359/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3359/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3359/ |
cchaos
suggested changes
Apr 21, 2020
| @@ -39,6 +39,8 @@ export const euiDatePickerDefaultTimeFormat = 'hh:mm A'; | |||
|
|
|||
| const DatePicker = _ReactDatePicker as typeof ReactDatePicker; | |||
|
|
|||
| export type EuiDatePickerPopoverPlacement = ReactDatePickerProps['popperPlacement']; | |||
There was a problem hiding this comment.
I wouldn't create a whole new type and export it here. Instead just add this directly to the prop below
Comment on lines
+36
to
+39
| type popperPlacement = | ||
| | 'bottom' | ||
| | 'bottom-end' | ||
| | 'bottom-start' |
Co-Authored-By: Caroline Horn <[email protected]>
elizabetdev
changed the title
…ement-prop-to-EuiDatePicker
…ement-prop-to-EuiDatePicker
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3359/ |
cchaos
reviewed
Apr 21, 2020
cchaos
reviewed
Apr 21, 2020
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3359/ |
cchaos
approved these changes
Apr 21, 2020
|
Thanks @cchaos! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3356.
Closes #2889.
Closes #2752.
The
popperPlacementprop is part of the ReactDatePicker and I'm just exposing it in our documentation.I noticed that the
openToDateprop is repeated in bothdate_picker.tsxfile andreact-datepicker.d.tsand I followed this example in order to expose thepopperPlacementprop in our documentation.I also changed the Date picker range demo by adding
popperPlacement="bottom-end". I think the design looks better this way.Checklist
[ ] Checked in mobile[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes