Eui license headers #3314
Eui license headers #3314
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3314/ |
There was a problem hiding this comment.
Ran yarn lint-es-fix and looked through the changes. A couple questions related to:
Not in scope: non-published/non-source files like build scripts, configurations, and docs.
src/webpack.config.jsgets the header. Is this correct?- Nothing in
src/components/icon/assetsgets the header. Is this correct?
There was a problem hiding this comment.
Ran locally. I also tested manually in files to make sure the linting was autofixing correctly. Agree on the icons, though it likely gets tricky around the third party logos. We could exclude files in assets that match assets/**/*logo*.
I think we can make a separate PR to remove the framer directory at this point.
|
Good catches! src/webpack.config.js doesn't need the header, but wouldn't hurt either; I'd rather keep it as is (in scope) than muddy the configuration setup Icons I talked with @peterschretlen and we're in agreement, which he summed up nicely:
Additionally, as Dave pointed out, we are vendoring 3rd party icons. These likely will need to have some kind of mention in NOTICE.txt, but that resolution will be handled in a future PR after getting input from legal. |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3314/ |
|
More Jest OOMs. jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3314/ |
Adds EUI's license header to the top of
ts,tsx, andjsfiles in src. Not in scope: non-published/non-source files like build scripts, configurations, and docs. The SCSS files also do not require headers.react-datepickerand@types/react-datepickerlicensesNote: license headers haven't actually been added yet to keep the configuration changes in this PR easy to review. I'll add them via
yarn lint-es-fixbefore merging.