-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading TypeScript to 3.7.2 #3295
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
data_grid.test.tsx Needs a second ignore comment, // @ts-ignore-next-line
columnSorter
.find('EuiSwitch')
.props()
// @ts-ignore-next-line
.onChange(); observer.ts Looks like it's an issue with changes to // React.Props<T> is now deprecated, which means that the `children`
// property is not available on `P` by default, even though you can
// always pass children as variadic arguments to `createElement`.
// In the future, if we can define its call signature conditionally
// on the existence of `children` in `P`, then we should remove this.
readonly props: Readonly<P> & Readonly<{ children?: ReactNode }>; but can be fixed in the EUI component with: const props: BaseProps = this.props;
return props.children(this.updateChildNode); package.json
yarn.lock Changing the above dependencies will create an issue with yarn which needs a manual resolution:
CHANGELOG.md Needs a breaking change entry |
Merged master into this branch to get the changelog entry into the right location, as we released an EUI version yesterday. I also removed the jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3295/ |
Jest OOMed. jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3295/ |
Summary
Closes #3292
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for accessibility including keyboard-only and screenreader modes