-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiBadge] Fix the inline styles being wiped by consumer passed styles #3284
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
💚 CLA has been signed |
jenkis test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3284/ |
jenkins test this |
Welcome @tiaanduplessis !! Thanks for taking on this issue. I'm running it locally to test and added a custom border style via the You'll need to add to make sure that the I have also update the checklist in the PR summary of items that should still be checked/added, even though it's such a small change. Since this is a bug fix we need to ensure we don't re-create the bug again. |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3284/ |
…fined for EuiBadge
Hi @cchaos 👋 I've made updates for the case that |
retest |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3284/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thanks @tiaanduplessis! I'll commit the Changelog suggestion for you and get this merged. 🥇
retest |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3284/ |
Awesome! Thanks @cchaos |
Summary
Closes #3282 where the inline styles for EuiBadge are being wiped by consumer passed inline styles.
Checklist
[ ] Checked in mobile[ ] Props have proper autodocs[ ] Added documentation examples[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes