-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add elasticsearch specific field type tokens #3165
Conversation
Preview documentation changes for this PR: https://eui.elastic.co/pr_3165/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3165/ |
…prove join, binary and percolator tokens.
Preview documentation changes for this PR: https://eui.elastic.co/pr_3165/ |
@mdefazio Can you add screenshots of the design files for each so we can view the pixel grid alignment? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Icons LGTM in the preview documentation. Thanks for working on this @mdefazio!
I had a feeling you were going to ask @cchaos ;) As I mentioned, the completion suggester isn't aligned yet as I knew I wanted to tweak that anyway. Should have a new version shortly though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
Preview documentation changes for this PR: https://eui.elastic.co/pr_3165/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3165/ |
Something funky is happening with the DnD tests. @mdefazio Can you revert just the changes to the drag-and-drop snapshots? |
Also, don't forget to add a changelog entry. |
This reverts commit 2756a28.
Preview documentation changes for this PR: https://eui.elastic.co/pr_3165/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are passing 🎉 Tokens lgtm. Some of the 1.5 strokes are slightly fuzzy on non-retina's but because they're thicker rather than thinner than 1px, you the lines are still visible.
Still, don't forget to add a changelog entry.
Preview documentation changes for this PR: https://eui.elastic.co/pr_3165/ |
1 similar comment
Preview documentation changes for this PR: https://eui.elastic.co/pr_3165/ |
@mdefazio It looks like these tokens are missing from our Figma library. Can you add them? |
Summary
Adds the following tokens to the EUI token list.
Will close elastic/kibana#58036
Will close elastic/kibana#61003
Checklist
Checked in mobile