Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elasticsearch specific field type tokens #3165

Merged
merged 13 commits into from
Mar 30, 2020

Conversation

mdefazio
Copy link
Contributor

@mdefazio mdefazio commented Mar 25, 2020

Summary

Adds the following tokens to the EUI token list.
Will close elastic/kibana#58036
Will close elastic/kibana#61003

  • Binary
  • Completion Suggester
  • Flattened
  • Join
  • Dense Vector
  • Keyword
  • Percolator
  • Rank feature
  • Rank features
  • Token Count
  • Text
  • Search-as-you-type
  • Histogram

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@mdefazio mdefazio self-assigned this Mar 25, 2020
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3165/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3165/

@mdefazio mdefazio marked this pull request as ready for review March 26, 2020 14:56
@mdefazio mdefazio added the icons label Mar 26, 2020
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3165/

@cchaos
Copy link
Contributor

cchaos commented Mar 26, 2020

@mdefazio Can you add screenshots of the design files for each so we can view the pixel grid alignment?

Copy link

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icons LGTM in the preview documentation. Thanks for working on this @mdefazio!

@mdefazio
Copy link
Contributor Author

I had a feeling you were going to ask @cchaos ;)

As I mentioned, the completion suggester isn't aligned yet as I knew I wanted to tweak that anyway. Should have a new version shortly though.

image

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3165/

@mdefazio
Copy link
Contributor Author

Updated screenshot of tokens with grid
image

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3165/

@cchaos
Copy link
Contributor

cchaos commented Mar 30, 2020

Something funky is happening with the DnD tests. @mdefazio Can you revert just the changes to the drag-and-drop snapshots?

@cchaos
Copy link
Contributor

cchaos commented Mar 30, 2020

Also, don't forget to add a changelog entry.

This reverts commit 2756a28.
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3165/

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing 🎉 Tokens lgtm. Some of the 1.5 strokes are slightly fuzzy on non-retina's but because they're thicker rather than thinner than 1px, you the lines are still visible.

Still, don't forget to add a changelog entry.

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3165/

1 similar comment
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3165/

@cchaos
Copy link
Contributor

cchaos commented Oct 21, 2021

@mdefazio It looks like these tokens are missing from our Figma library. Can you add them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants