-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add href support for default actions in Basic Table #3115
Add href support for default actions in Basic Table #3115
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
💚 CLA has been signed |
Thanks @thefaded , Can you please sign the CLA and describe in the PR summary the actions you took to fix the issue? |
@cchaos, sure. I'm also updated changelog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I add samples to docs with href? (from #1792 (comment))
Yes, updating one or two specific actions with href
would be great. Would also love to see a third action added to src/components/basic_table/collapsed_item_actions.test.tsx so we can better prevent future regressions.
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3115/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM; pulled & tested locally
@thefaded Can you also update this doc example's action item from using an eui/src-docs/src/views/tables/actions/actions.js Lines 188 to 194 in 2bc9917
|
Jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3115/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay on this. I just realized there is a docs example added already. I've fixed merge conflicts and once the build passes, I'll merge. Thanks @thefaded !
Summary
Fixes : #1792
EuiBasicTable
default action accepts support bothhref
oronClick
Checklist