Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add href support for default actions in Basic Table #3115

Merged
merged 6 commits into from
Apr 6, 2020
Merged

Add href support for default actions in Basic Table #3115

merged 6 commits into from
Apr 6, 2020

Conversation

thefaded
Copy link
Contributor

@thefaded thefaded commented Mar 18, 2020

Summary

Fixes : #1792

EuiBasicTable default action accepts support both href or onClick

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Mar 18, 2020

💚 CLA has been signed

@cchaos
Copy link
Contributor

cchaos commented Mar 18, 2020

Thanks @thefaded , Can you please sign the CLA and describe in the PR summary the actions you took to fix the issue?

@thefaded
Copy link
Contributor Author

@cchaos, sure. I'm also updated changelog.

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I add samples to docs with href? (from #1792 (comment))

Yes, updating one or two specific actions with href would be great. Would also love to see a third action added to src/components/basic_table/collapsed_item_actions.test.tsx so we can better prevent future regressions.

CHANGELOG.md Outdated Show resolved Hide resolved
src-docs/src/views/tables/actions/actions.js Outdated Show resolved Hide resolved
src/components/basic_table/collapsed_item_actions.tsx Outdated Show resolved Hide resolved
@thefaded thefaded requested a review from chandlerprall March 23, 2020 11:37
@chandlerprall
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3115/

@chandlerprall chandlerprall requested a review from cchaos March 24, 2020 20:55
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM; pulled & tested locally

@cchaos
Copy link
Contributor

cchaos commented Mar 25, 2020

@thefaded Can you also update this doc example's action item from using an onClick to an href: '#'?

name: 'Share',
isPrimary: true,
description: 'Share this user',
icon: 'share',
type: 'icon',
onClick: () => {},
'data-test-subj': 'action-share',

@cchaos
Copy link
Contributor

cchaos commented Apr 6, 2020

Jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3115/

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay on this. I just realized there is a docs example added already. I've fixed merge conflicts and once the build passes, I'll merge. Thanks @thefaded !

@cchaos cchaos merged commit b2078b1 into elastic:master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EuiBasicTable default action should support both href and onClick
4 participants