Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add link to Figma UI Kit #3016

Merged
merged 6 commits into from
Mar 10, 2020

Conversation

elizabetdev
Copy link
Contributor

Summary

Closes #3014.

This PR adds a link to the Figma UI Kit into the home page.

Screenshot 2020-03-09 at 18 18 11

The Figma icon was optimized and resized to the same size as other third-parties icons. It was used as a custom SVG as mentioned on #3014.

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • [ ] Props have proper autodocs
  • [ ] Added documentation examples
  • [ ] Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • [ ] A changelog entry exists and is marked appropriately

@elizabetdev elizabetdev requested review from snide and cchaos March 9, 2020 18:40
@snide snide mentioned this pull request Mar 9, 2020
4 tasks
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3016/

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like that you changed "Sketch" to just "Libraries". You might want to add a tooltip around the Figma one as well for those unfamiliar with the logo.

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3016/

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😻 Thanks for adding this. Just had one extra comment for the old Sketch link

src-docs/src/views/home/home_view.js Show resolved Hide resolved
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as @cchaos. Thanks for adding this quick. Good to merge once changes are in.

@snide
Copy link
Contributor

snide commented Mar 9, 2020

cc @hbharding so he's aware there will be a more prominent link.

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3016/

CHANGELOG.md Outdated Show resolved Hide resolved
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3016/

@elizabetdev elizabetdev merged commit edea459 into elastic:master Mar 10, 2020
@hbharding
Copy link
Contributor

Thanks @miukimiu !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to Figma UI Kit
5 participants