-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Google G logo to third party logos #2853
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
I just suggest optimizing the SVG a little bit more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to go after an upstream merge. Probably want to double check your changelog is still against master.
Preview documentation changes for this PR: https://eui.elastic.co/pr_2853/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_2853/ |
Summary
Fixes #2811
Note: Some files I didn't directly edit have been updated. I'm guessing this is a result of running
yarn compile-icons
Checklist
- [] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes