Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google G logo to third party logos #2853

Merged
merged 7 commits into from
Feb 24, 2020

Conversation

andreadelrio
Copy link
Contributor

@andreadelrio andreadelrio commented Feb 13, 2020

Summary

Fixes #2811
image

Note: Some files I didn't directly edit have been updated. I'm guessing this is a result of running yarn compile-icons

Checklist

- [] Check against all themes for compatibility in both light and dark modes
- [ ] Checked in mobile
- [ ] Checked in IE11 and Firefox
- [ ] Props have proper autodocs

  • Added documentation examples
  • Added or updated jest tests
    - [ ] Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

Copy link
Contributor

@elizabetdev elizabetdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

I just suggest optimizing the SVG a little bit more.

src/components/icon/assets/logo_google_g.svg Outdated Show resolved Hide resolved
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to go after an upstream merge. Probably want to double check your changelog is still against master.

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_2853/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_2853/

@andreadelrio andreadelrio merged commit dc12039 into elastic:master Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Google logo to EuiIcons
4 participants