Improve compressed EuiPagination #2779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandlerprall
suggested changes
Jan 21, 2020
|
Love the VoiceOver gif ❤️ |
snide
reviewed
Jan 21, 2020
snide
suggested changes
Jan 22, 2020
|
Removed hideOnMobile. Screenshot at iPhone X screen size:
|
snide
approved these changes
Jan 23, 2020
|
@chandlerprall Mind giving this a quick check. I think @andreadelrio addressed all your feedback and this looks good to merge? |
chandlerprall
suggested changes
Jan 24, 2020
chandlerprall
approved these changes
Jan 24, 2020
There was a problem hiding this comment.
Changes LGTM! Pulled & tested locally. Thanks @andreadelrio !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've added the current page and a "jump to last page" link to the compressed version of
EuiPagination. See before and after screenshots belowBefore
After
EuiPaginationusing VoiceOver.Fixes #606
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [x] Checked for accessibility including keyboard-only and screenreader modes