-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds toolbarAdditionalControls prop to EuiDataGrid #2594
Conversation
I wonder if we should merge (otherwise this PR LGTM) |
@chandlerprall I think that would be elegant. The only downside I can think to that proposal would be:
I think I'd likely need a session to figure out how to handle the typing for something like that if we wanted to go in that direction. I'm personally indifferent from the application perspective, so i'll leave it to you for the call. |
Not sure we're envisioning the prop the same way,
|
@chandlerprall Ahhhh. I got you. Thats much easier. I can do that and think that's a good idea! |
@chandlerprall Changes made. I kept the |
…typeguard to more exactly specify the return type
Got a PR for you on the typescript side of things, to make the helper utility's return type more explicit. snide#10 |
Typo fix; more explicit return type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM; tested locally
Summary
Crosses off a line item from #2504
Added a new prop
toolbarVisibility.additionalControls
which accepts a ReactNode for placing extra buttons within the toolbar. I put these in between the current controls and the full screen for a couple reasons.Questions
I briefly considered making a component for these buttons, but really all they do is add a class on top of
EuiButtonEmpty
and i felt like making a shim component for that reason alone seemed like overkill, though if people think that's a good idea to abstract away the css class I can do that.Checklist
Checked for breaking changes and labeled appropriately