-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes bug in the EuiCheckboxGroup
demo page and add disabled
to TS defs
#2545
Conversation
…nd disabled groups were using the same ids for their checkbox input components, which caused the disabled ones to be checkable
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
EuiCheckboxGroup
demo page in which both enabled a…EuiCheckboxGroup
demo page in which both enabled a…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for that change @ffknob .
One of the things we use the documentation page for is to visually test the different states of a component. With all the disabled checkboxes being unchecked now, we can't visually see what the state of a disabled and checked checkbox would look like. That's most likely the reason we kept the id's the same which is simply to check the look of this state.
Could you look into creating a different checkboxIdToSelectedMap
state for the disabled options and by default set one of them to checked?
How about that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's great, thank you!
Jenkins, test this |
EuiCheckboxGroup
demo page in which both enabled a…EuiCheckboxGroup
demo page and add disabled
to TS defs
Related to #2538
Fixes bug in the
EuiCheckboxGroup
demo page in which both enabled and disabled groups were using the same ids for their checkbox input components, which caused the disabled ones to be checkableChecklist
[ ] Checked in dark mode[ ] Checked in mobile[ ] Checked in IE11 and Firefox[ ] Props have proper autodocs[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes