Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aspect ratio component #2535

Merged
merged 9 commits into from
Nov 21, 2019
Merged

Aspect ratio component #2535

merged 9 commits into from
Nov 21, 2019

Conversation

snide
Copy link
Contributor

@snide snide commented Nov 15, 2019 •
edited
Loading

Summary

EuiAspectRatio provides a way to responsively resize a single block level child element to a specified ratio. This is useful for things like YouTube iframes that initially have a fixed size.

Note

I cleaned up our yeoman template as well in the process of this PR.

image

image

Checklist

  • Checked in dark mode
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@snide snide changed the title [WIP] Aspect ratio component Aspect ratio component Nov 21, 2019
@snide snide marked this pull request as ready for review November 21, 2019 03:10
@snide snide requested a review from thompsongl November 21, 2019 03:12
thompsongl
thompsongl reviewed Nov 21, 2019
View reviewed changes
src/components/aspect_ratio/index.ts Outdated Show resolved Hide resolved
src/components/aspect_ratio/aspect_ratio.tsx Outdated Show resolved Hide resolved
src-docs/src/views/aspect_ratio/aspect_ratio_example.js Outdated Show resolved Hide resolved
@snide
Copy link
Contributor Author

snide commented Nov 21, 2019

Feedback addressed.

thompsongl
thompsongl approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Component code LGTM

@snide snide merged commit 4096943 into elastic:master Nov 21, 2019
@snide snide deleted the feature/aspect branch November 21, 2019 19:54
@thompsongl thompsongl mentioned this pull request Dec 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos left review comments

@thompsongl thompsongl thompsongl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snide @cchaos @thompsongl