Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aira-modal typo #2488

Merged
merged 2 commits into from
Oct 24, 2019
Merged

Fix aira-modal typo #2488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13aaff6
aira-modal???
thompsongl Oct 24, 2019
0113582
CL
thompsongl Oct 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
**Bug fixes**

- Normalized button `moz-focus-inner` ([#2445](https://github.com/elastic/eui/pull/2445))
- Fixed typo to correct `aria-modal` attribute in`EuiPopover` ([#2488](https://github.com/elastic/eui/pull/2488))

## [`14.8.0`](https://github.com/elastic/eui/tree/v14.8.0)

Expand Down
14 changes: 7 additions & 7 deletions src/components/form/super_select/__snapshots__/super_select.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,9 +179,9 @@ exports[`EuiSuperSelect props custom display is propagated to dropdown 1`] = `
data-focus-lock-disabled="disabled"
>
<div
aira-modal="true"
aria-describedby="htmlId"
aria-live="assertive"
aria-modal="true"
class="euiPanel euiPopover__panel euiPopover__panel--bottom euiPopover__panel-noArrow euiSuperSelect__popoverPanel"
role="dialog"
style="top: 8px; left: -22px; z-index: 2000;"
Expand Down Expand Up @@ -389,9 +389,9 @@ exports[`EuiSuperSelect props more props are propogated to each option 1`] = `
data-focus-lock-disabled="disabled"
>
<div
aira-modal="true"
aria-describedby="htmlId"
aria-live="assertive"
aria-modal="true"
class="euiPanel euiPopover__panel euiPopover__panel--bottom euiPopover__panel-noArrow euiSuperSelect__popoverPanel"
role="dialog"
style="top: 8px; left: -22px; z-index: 2000;"
Expand Down Expand Up @@ -763,9 +763,9 @@ exports[`EuiSuperSelect props more props are propogated to each option 2`] = `
data-focus-lock-disabled="disabled"
>
<div
aira-modal="true"
aria-describedby="htmlId"
aria-live="assertive"
aria-modal="true"
class="euiPanel euiPopover__panel euiPopover__panel--bottom euiPopover__panel-noArrow euiSuperSelect__popoverPanel"
role="dialog"
style="top: 8px; left: -22px; z-index: 2000;"
Expand Down Expand Up @@ -855,9 +855,9 @@ exports[`EuiSuperSelect props more props are propogated to each option 2`] = `
data-focus-lock-disabled="disabled"
>
<div
aira-modal="true"
aria-describedby="htmlId"
aria-live="assertive"
aria-modal="true"
class="euiPanel euiPopover__panel euiPopover__panel--bottom euiPopover__panel-noArrow euiSuperSelect__popoverPanel"
role="dialog"
style="top: 8px; left: -22px; z-index: 2000;"
Expand Down Expand Up @@ -941,9 +941,9 @@ exports[`EuiSuperSelect props more props are propogated to each option 2`] = `
/>
</SideEffect(FocusWatcher)>
<EuiPanel
aira-modal="true"
aria-describedby="htmlId"
aria-live="assertive"
aria-modal="true"
className="euiPopover__panel euiPopover__panel--bottom euiPopover__panel-noArrow euiSuperSelect__popoverPanel"
paddingSize="none"
panelRef={[Function]}
Expand All @@ -957,9 +957,9 @@ exports[`EuiSuperSelect props more props are propogated to each option 2`] = `
}
>
<div
aira-modal="true"
aria-describedby="htmlId"
aria-live="assertive"
aria-modal="true"
className="euiPanel euiPopover__panel euiPopover__panel--bottom euiPopover__panel-noArrow euiSuperSelect__popoverPanel"
role="dialog"
style={
Expand Down Expand Up @@ -1222,9 +1222,9 @@ exports[`EuiSuperSelect props options are rendered when select is open 1`] = `
data-focus-lock-disabled="disabled"
>
<div
aira-modal="true"
aria-describedby="htmlId"
aria-live="assertive"
aria-modal="true"
class="euiPanel euiPopover__panel euiPopover__panel--bottom euiPopover__panel-noArrow euiSuperSelect__popoverPanel"
role="dialog"
style="top: 8px; left: -22px; z-index: 2000;"
Expand Down
10 changes: 5 additions & 5 deletions src/components/popover/__snapshots__/popover.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,9 +132,9 @@ exports[`EuiPopover props isOpen renders true 1`] = `
data-focus-lock-disabled="disabled"
>
<div
aira-modal="true"
aria-describedby="htmlId"
aria-live="assertive"
aria-modal="true"
class="euiPanel euiPanel--paddingMedium euiPopover__panel euiPopover__panel--bottom euiPopover__panel-isOpen"
role="dialog"
style="top: 16px; left: -22px; z-index: 2000;"
Expand Down Expand Up @@ -182,9 +182,9 @@ exports[`EuiPopover props ownFocus defaults to false 1`] = `
data-focus-lock-disabled="disabled"
>
<div
aira-modal="true"
aria-describedby="htmlId"
aria-live="assertive"
aria-modal="true"
class="euiPanel euiPanel--paddingMedium euiPopover__panel euiPopover__panel--bottom euiPopover__panel-isOpen"
role="dialog"
style="top: 16px; left: -22px; z-index: 2000;"
Expand Down Expand Up @@ -232,9 +232,9 @@ exports[`EuiPopover props ownFocus renders true 1`] = `
data-focus-lock-disabled="false"
>
<div
aira-modal="true"
aria-describedby="htmlId"
aria-live="off"
aria-modal="true"
class="euiPanel euiPanel--paddingMedium euiPopover__panel euiPopover__panel--bottom euiPopover__panel-isOpen"
data-autofocus="true"
role="dialog"
Expand Down Expand Up @@ -290,9 +290,9 @@ exports[`EuiPopover props panelClassName is rendered 1`] = `
data-focus-lock-disabled="disabled"
>
<div
aira-modal="true"
aria-describedby="htmlId"
aria-live="assertive"
aria-modal="true"
class="euiPanel euiPanel--paddingMedium euiPopover__panel euiPopover__panel--bottom euiPopover__panel-isOpen test"
role="dialog"
style="top: 16px; left: -22px; z-index: 2000;"
Expand Down Expand Up @@ -340,9 +340,9 @@ exports[`EuiPopover props panelPaddingSize is rendered 1`] = `
data-focus-lock-disabled="disabled"
>
<div
aira-modal="true"
aria-describedby="htmlId"
aria-live="assertive"
aria-modal="true"
class="euiPanel euiPanel--paddingSmall euiPopover__panel euiPopover__panel--bottom euiPopover__panel-isOpen"
role="dialog"
style="top: 16px; left: -22px; z-index: 2000;"
Expand Down
2 changes: 1 addition & 1 deletion src/components/popover/popover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,7 +642,7 @@ export class EuiPopover extends Component<Props, State> {
tabIndex={tabIndex}
aria-live={ariaLive}
role="dialog"
aira-modal="true"
aria-modal="true"
aria-describedby={descriptionId}
style={this.state.popoverStyles}>
<div className={arrowClassNames} style={this.state.arrowStyles} />
Expand Down