-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Icon] Update Observability app icons #2430
[Icon] Update Observability app icons #2430
Conversation
Replaced the existing Infra app icon with the new metrics.
@snide What would be the process for changing the variable name from |
I got ya, just feed the icons in. Is there one for logging as well? #2431 |
And yes, if you want to change the name, we'll just need to change that in the Kibana PR when we merge it. I can remember that as well. We'll ignore it as a breaking change because that logo is super specific. |
Sounds good @snide - thanks! |
Replacing the existing loggingApp icon and renamed to make it consistent with its solution name.
Make it consistent with its solution name.
# Conflicts: # CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previewed locally including the nav drawer page and everything looks good. File changes look correct, as well.
@ryankeairns Thanks for doing a review. I'll merge now |
Summary
Updating the app icons for Metrics (previously Infrastructure) and Logs to make them consistent with their solution logos, as it's the case with the other Observability apps (Code and APM).
Checklist
Checked in mobileChecked in IE11 and FirefoxProps have proper autodocsAdded documentation examplesChecked for breaking changes and labeled appropriatelyChecked for accessibility including keyboard-only and screenreader modes