[sideNavItem] no need for justify-content: space-between #2297
Conversation
|
@spalger The space-between is actually necessary for when there is a caret indicating children of the nav item. You can see an example via the EUI doc's side nav. We may need to actually group the icon and text together or ensure that the icon and caret never grow. |
|
Nice catch @cchaos I've grouped the icon and label together like you mentioned, but I'm not sure about naming. Should I even bother adding a class to the span since it's not necessary for styling?
|
|
Now you're starting to see what we have to deal with 😜 ... This dom layout breaks the truncation.
You're best best is to leave elements as they were, and instead remove the |
|
Yes, yes, that seems like the right way to do this
|
* [sideNavItem] no need for justify-content: space-between * add changelog entry * group the icon and label so that they don't get spaced out * remove unnecessary classname * rather than negotiating spacing, grow the label so it takes up available space * update and bump changelog entry to master
Summary
Fixed #2296 by removing
justify-content: space-between;from sideNavItem buttons, rather than starting withspace-betweenand overwriting nearly everything withjustify-content: flex-start;.Checklist
Props have proper autodocsAdded or updated jest testsChecked for breaking changes and labeled appropriatelyChecked for accessibility including keyboard-only and screenreader modes