Added more icons from design files #228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snide
approved these changes
Dec 20, 2017
There was a problem hiding this comment.
Looks good. Only thing I noticed is the info and question in circle items are different sizes.
Dunno what do about that stuff really. Sometimes we make these things smaller within the canvas because we want those specific icons to be lesser weight (like info). But should people just use the prop sizing for that?
No big deal cuz we can change it anytime. Also asked @cchaos to re-export the other face icons, which break in dark mode.
|
Yeah I noticed that in the design files too. I think it's ok to have some icons that are slightly smaller than fully 16x16 since sizing doesn't allow for granularity like 15x15 and still have it align nicely with the baseline. |
Buttons now correctly align regardless of if they have icons next to them.
help / error text didn't have line-height.
…tColor (elastic#235) * Rename euiFlexGroup--alignItemsEnd to euiFlexGroup--alignItemsFlexEnd. * Remove support for 'primary' color from EuiTextColor because it looks too much like a link. * Use flex groups in EuiButton examples.
Popovers with titles no longer require padding to be manually added to the popover's child that follows the title.
* toast jest tests * using test style guide this time * test each color value
* Fix bug with Pager service when there are no items.
* Support newlines in EuiErrorBoundary.
* Change Pager to use -1 to reflect a 'no items' state. * Add isPageable method to Pager.
* Writing guidelines Provides descriptions and examples of how to write UI text * Added code for checkbox Also fixed typos and added don't for contractions * Incorporated review comments Added more detail and explanations * Second round of edits Added some more don'ts and fixed examples
|
Closing because rebase got weird, new one at #243 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The List:
asterisk.svg
calendar.svg
checkInCircleFilled.svg
exit.svg
expand.svg
faceNeutral.svg
iInCircle.svg
number.svg
pause.svg
play.svg
popout.svg
refresh.svg
scale.svg
share.svg -- updated not added
sortLeft.svg
sortRight.svg
starPlusFilled.svg
string.svg
tableOfContents.svg