-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add overflow: hidden
to .euiModal__flex
#2164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with this. I agree that it doesn't close the long title issues, but it's definitely less broken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I gave up on verifying this in Kibana (I can't figure out the new linking; Kibana keeps crashing), but it does work as described in my local EUI docs. I'll check it again once Kibana is updated with this new EUI build.
It was discovered in Kibana that even non-breaking words in code blocks inside of modals causes the content to overflow the body even though code blocks are setup to scroll.
https://d.pr/free/v/l0r1A1
This just hides any overflow from
.euiModal__flex
. Here's some tests in EUI docs:Code blocks
Before
After
Also fixes #1762
Also "fixes" long titles #1766 #1384
... though it just really cuts it off and doesn't force it to break the word so I'm hesistent to call the above issues fixed and closed.
Checklist
[ ] This was checked in dark mode[ ] Any props added have proper autodocs[ ] Documentation examples were added[ ] This was checked for breaking changes and labeled appropriately[ ] Jest tests were updated or added to match the most common scenarios[ ] This was checked against keyboard-only and screenreader scenarios[ ] This required updates to Framer X components