Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added partial glyph to EuiIcon #2152

Merged
merged 4 commits into from
Jul 23, 2019
Merged

Added partial glyph to EuiIcon #2152

merged 4 commits into from
Jul 23, 2019

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Jul 22, 2019

Request came from Maps to indicate when results are only showing partial results not the full set.

Screen Shot 2019-07-22 at 14 27 20 PMScreen Shot 2019-07-22 at 14 27 31 PM

And the pixel grid:

Screen Shot 2019-07-22 at 14 25 50 PM

Checklist

  • [ ] This was checked in mobile
  • [ ] This was checked in IE11
  • This was checked in dark mode
  • [ ] Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • [ ] This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • [ ] This was checked against keyboard-only and screenreader scenarios
  • [ ] This required updates to Framer X components

@cchaos cchaos added the icons label Jul 22, 2019
@cchaos cchaos requested review from snide and ryankeairns July 22, 2019 18:30
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, the rounded dashes are a nice touch!

@cchaos cchaos merged commit 72c3d97 into elastic:master Jul 23, 2019
@cchaos cchaos deleted the partial-icon branch July 23, 2019 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants