Update combobox option's value TS definition #2080
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2078 by updating the typescript definition for EuiComboBox's options'
value
.I tested these changes in a new project to verify the generic was understood properly -

I also dropped the resulting eui.d.ts file into Kibana and ran the typecheck script, there are two instances in x-pack/legacy/plugins/siem/public/components/edit_data_provider/index.tsx where
EuiComboBox
is used throughstyled-components
which interprets the generic as{}
which is invalid. Both cases are solved by moving the css style ontoEuiComboBox
as a prop.Checklist
- [ ] This was checked in mobile- [ ] This was checked in IE11- [ ] This was checked in dark mode- [ ] Any props added have proper autodocs- [ ] Documentation examples were added- [ ] Jest tests were updated or added to match the most common scenarios- [ ] This was checked against keyboard-only and screenreader scenarios- [ ] This required updates to Framer X components