-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add magnifyWithMinus and magnifyWithPlus (aka zoom) icons #2056
Conversation
02a4e14
to
d001aea
Compare
@ryankeairns Can you commit the icons to Abstract as well so I can view the pixel grid? |
@cchaos done! They're based on the existing Search icon, then I centered the minus and plus leaving a two pixel gap. This means they're on subpixels, but it keeps them centered and with a 1 pixel weight. |
I'll post up a version with a smaller magnifying glass where the plus/minus is not on subpixels. |
@cchaos If we're ok with shrinking the magnifying glass by a pixel, then we end up with this. By 'ok' I mean, we should probably then do the same to the existing search icon (though we don't have to). at 16pxzoomed in for detail |
Yeah, I'd opt for making sure they're aligned to the pixel grid. I think ensuring readability (less fuzziness) for those without retina displays is more important than trying to match sizing with other semi-related icons. I can't imagine when the normal magnify would be used in conjunction with these. If we do see that case, we can revisit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks
Fixes #2045
Summary
Adds magnifyWithMinus (zoom out) and magnifyWithPlus (zoom in) icons with genericized/literal names.
Light mode
Dark mode
Checklist
This was checked in mobileThis was checked in IE11Any props added have proper autodocsThis was checked for breaking changes and labeled appropriatelyJest tests were updated or added to match the most common scenariosThis was checked against keyboard-only and screenreader scenariosThis required updates to Framer X components