Adding jsx-a11y linter rules #1952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep. Figure we can take it over the line
…On Tue, May 28, 2019, 4:04 PM Greg Thompson ***@***.***> wrote:
@bhavyarm <https://github.com/bhavyarm> @snide <https://github.com/snide>
Is the idea with this PR that EUI folks will push commits directly to this
branch?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1952?email_source=notifications&email_token=AACPHJ5AXIZXDLEZY7MLP6DPXW275A5CNFSM4HOV6EOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWNV7OQ#issuecomment-496721850>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACPHJ3DI7J3LUDAEEOFTP3PXW275ANCNFSM4HOV6EOA>
.
|
|
Sounds good! |
thompsongl
reviewed
May 30, 2019
thompsongl
reviewed
May 30, 2019
snide
reviewed
May 31, 2019
snide
approved these changes
May 31, 2019
| @@ -56,7 +58,7 @@ EuiCopy.propTypes = { | |||
| /** | |||
| * Tooltip message displayed before copy function is called. | |||
| */ | |||
| beforeMessage: PropTypes.string, | |||
| beforeMessage: PropTypes.node, | |||
There was a problem hiding this comment.
Make sure to list this in the CL I guess.
There was a problem hiding this comment.
Ah yeah I meant to comment here. Reason for this is that we put WCAG level badges inside the tooltip for color copying, which is absolutely reasonable but results in prop type warnings.
|
Thank you very very much @thompsongl |
|
A couple more changes incoming. I guess the tslint -> eslint migration stirred up some things. |
thompsongl
reviewed
May 31, 2019
| @@ -522,6 +522,8 @@ export class EuiIcon extends Component<Props, State> { | |||
| if (typeof icon === 'string') { | |||
| return ( | |||
| <img | |||
| // TODO: Allow alt prop | |||
|
@snide mind taking another look at this? There's been a few additions since your review |
snide
approved these changes
Jun 4, 2019
|
jenkins test this |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding jsx-a11y linter rules: https://www.npmjs.com/package/eslint-plugin-jsx-a11y