Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

token_map converted to TS #1870

Merged
merged 4 commits into from
Apr 25, 2019
Merged

token_map converted to TS #1870

merged 4 commits into from
Apr 25, 2019

Conversation

theodesp
Copy link
Contributor

@theodesp theodesp commented Apr 23, 2019 •
edited
Loading

Summary

Converted token_map to TS

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

thompsongl
thompsongl reviewed Apr 23, 2019
View reviewed changes
src/components/token/token_map.ts Outdated Show resolved Hide resolved
src/components/token/token_map.ts Show resolved Hide resolved
chandlerprall
chandlerprall suggested changes Apr 23, 2019
View reviewed changes
src/components/token/token_map.ts Outdated Show resolved Hide resolved
@thompsongl
Copy link
Contributor

jenkins test this

@theodesp
Copy link
Contributor Author

pr updated

@thompsongl
Copy link
Contributor

Appreciate the help, @theodesp 🙌

jenkins test this

chandlerprall
chandlerprall approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

built eui.d.ts locally, exported values look good

@thompsongl thompsongl merged commit c151fd7 into elastic:master Apr 25, 2019
@chandlerprall chandlerprall mentioned this pull request May 2, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thompsongl thompsongl thompsongl approved these changes

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@theodesp @elasticmachine @thompsongl @chandlerprall