Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an invalid state to EuiSuperSelect #1804

Merged
merged 7 commits into from
Apr 8, 2019
Merged

Add an invalid state to EuiSuperSelect #1804

merged 7 commits into from
Apr 8, 2019

Conversation

snide
Copy link
Contributor

@snide snide commented Apr 6, 2019 •
edited
Loading

Summary

Fixes #1460

Sorry for the slow response on this one @cjcenizal. Must have come in on a busy day. Saw it when cleaning our backlog and was an easy enough fix.

image

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@snide snide requested a review from cchaos April 6, 2019 03:36
cchaos
cchaos suggested changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invalid={isInvalid} should be applied to the hidden input

src/components/form/super_select/super_select_control.js Outdated Show resolved Hide resolved
cjcenizal
cjcenizal approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, code LGTM! I'm not familiar enough with the role of the invalid prop to provide an opinion so I'll let you all hash it out... though it doe seem odd that we're using an HTML attribute that doesn't seem to exist. What happens if we remove that? Maybe it was originally a mistake?

@snide
Copy link
Contributor Author

snide commented Apr 8, 2019

@cjcenizal Yep. We resolved. @cchaos should be ready. Removed that HTML bit.

cchaos
cchaos approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@snide snide merged commit 77b4f88 into elastic:master Apr 8, 2019
@snide snide deleted the bug/invalid_ss branch April 8, 2019 18:42
@snide snide mentioned this pull request Apr 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcenizal cjcenizal cjcenizal approved these changes

@cchaos cchaos cchaos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EuiSuperSelect needs to implement isInvalid
3 participants
@snide @cchaos @cjcenizal