Make EuiPopover's repositionOnScroll prop optional in TS #1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
chandlerprall
added a commit
to chandlerprall/eui
that referenced
this pull request
Mar 11, 2019
* Make EuiPopover's repositionOnScroll prop optional in TS * changelog
chandlerprall
added a commit
that referenced
this pull request
Mar 11, 2019
* Update react-datepicker time selector to not _always_ scroll to preSelection time * Update react-datepicker time selection scroll-into-view onMount logic * revert props default changes I made for testing * fix scroll issue * fix ie issue * A few more dark mode fixes (#1700) * 9.2.0 * Updated documentation. * Make EuiPopover's repositionOnScroll prop optional in TS (#1705) * Make EuiPopover's repositionOnScroll prop optional in TS * changelog * fix range coloring * Fix scrollTop target * changelog
Shigawire
pushed a commit
to Shigawire/eui
that referenced
this pull request
May 10, 2019
* Update react-datepicker time selector to not _always_ scroll to preSelection time * Update react-datepicker time selection scroll-into-view onMount logic * revert props default changes I made for testing * fix scroll issue * fix ie issue * A few more dark mode fixes (elastic#1700) * 9.2.0 * Updated documentation. * Make EuiPopover's repositionOnScroll prop optional in TS (elastic#1705) * Make EuiPopover's repositionOnScroll prop optional in TS * changelog * fix range coloring * Fix scrollTop target * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make EuiPopover's repositionOnScroll prop optional in TS
Checklist
- [ ] This was checked in mobile- [ ] This was checked in IE11- [ ] This was checked in dark mode- [ ] Any props added have proper autodocs- [ ] Documentation examples were added- [ ] This was checked for breaking changes and labeled appropriately- [ ] Jest tests were updated or added to match the most common scenarios- [ ] This was checked against keyboard-only and screenreader scenarios- [ ] This required updates to Framer X components