Support multiple space-separated values within a single element's data-test-subj attribute

[cjcenizal]

I've tested this in the context of Kibana, and this change doesn't seem to break any tests.

[thompsongl]

👍 Makes sense to me

[chandlerprall]

Instead of always-on, how about passing a matcher to the function?

findTestSubject(comp, 'pagination page-button-1') // '=' default matcher
findTestSubject(comp, 'page-button-1', '~=') // whitespace-separated value
findTestSubject(comp, 'page-button-', '^=') // must start with

This way we can support all of the attribute selectors https://developer.mozilla.org/en-US/docs/Web/CSS/Attribute_selectors#Syntax

[cjcenizal]

@chandlerprall I think that's a great idea! How do you feel about ~= being the default? It seems like an enhancement to plain old = without any drawbacks. It also seems like a better DX, because I think there are a good number of people who would need to look the matcher syntax up to use it. 🖐

[chandlerprall]

@cjcenizal that sounds good to me

[cjcenizal]

@chandlerprall @thompsongl Updated with your feedback and added tests. Could you take another look please?

[thompsongl]

Thanks! A couple minor things

[thompsongl]

Merge remnants

[cjcenizal]

Whoops!

[thompsongl]

Could we add a link to the attribute selector spec or similar to give a complete view of what matcher options are available?

[cjcenizal]

Great idea!

[cjcenizal]

Thanks, peeps. Ready for another look.