Fix modal min-width issue in IE11 #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @LeeDr |
ryankeairns
requested changes
Sep 7, 2018
src/components/modal/_modal.scss
Outdated
| */ | ||
|
|
||
| .euiModal { | ||
| border: $euiBorderThin; | ||
| @include euiBottomShadowLarge($adjustBorders: true); | ||
| display: flex; /* 1 */ | ||
|
|
||
| position: relative; | ||
| position: relatie; |
There was a problem hiding this comment.
Looks like a misspell here.
There was a problem hiding this comment.
Oh. Good catch. My vim fingers must have slipped!
ryankeairns
approved these changes
Sep 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
IE has trouble with min-widths and flex boxes if not used as as a pixel value. This PR makes the min-width use our max-form width (400px) as the min-width we'd accept on a modal. I picked that value because it's good for short notices, and our modals tend to hold input values of some kind. I updated our default modal to not use style tags for width so this would be a better default for IE11.
Checklist