Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

euiHeader__notification needs to be a component? #87

Closed
bevacqua opened this issue Oct 30, 2017 · 0 comments · Fixed by #546
Closed

euiHeader__notification needs to be a component? #87

bevacqua opened this issue Oct 30, 2017 · 0 comments · Fixed by #546

Comments

@bevacqua
Copy link
Contributor

bevacqua commented Oct 30, 2017 •
edited
Loading

From the header bar example:

<span className='euiHeader__notification'>
  3
</span>

Expected interface:

<EuiHeaderNotification>3</EuiHeaderNotification>
@bevacqua bevacqua changed the title euiHeader__notification needs to be a component euiHeader__notification needs to be a component? Oct 30, 2017
cchaos pushed a commit to cchaos/eui that referenced this issue Mar 20, 2018
elastic#87 Converted .euiHeader__notification into `EuiHeaderNotifi…
f0798b4 
…cation`
@cchaos cchaos mentioned this issue Mar 20, 2018
Merged
cchaos pushed a commit to cchaos/eui that referenced this issue Mar 20, 2018
elastic#87 Converted .euiHeader__notification into `EuiHeaderNotifi…
08bc2e3 
…cation`
cchaos pushed a commit to cchaos/eui that referenced this issue Mar 22, 2018
elastic#87 Converted .euiHeader__notification into `EuiHeaderNotifi…
0b3f63f 
…cation`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Some random fixes cchaos/eui
1 participant
@bevacqua