Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select All Checkboxes on Tables Lacking Proper Labeling #746

Closed
aphelionz opened this issue May 1, 2018 · 2 comments · Fixed by #821
Closed

Select All Checkboxes on Tables Lacking Proper Labeling #746

aphelionz opened this issue May 1, 2018 · 2 comments · Fixed by #821
Labels
accessibility - WCAG A Level A WCAG Accessibility Criteria accessibility

Comments

@aphelionz
Copy link
Contributor

aphelionz commented May 1, 2018 •
edited
Loading

Steps to reproduce (assumes ChromeVox or similar)

  1. Open https://elastic.github.io/eui/#/display/tables in a new tab.
  2. Tab to the table under the "Adding selection to a BasicTable" heading.
  3. Tab to the the first "select all" checkbox in the table

Actual Result

"Checkbox Not Checked"

Expected Result

"Select All Rows. Checkbox not Checked"

Category: #688: Elastic UI Tables Accessibility
Relevant WCAG Criteria: 3.3.2 Labels or Instructions
@aphelionz aphelionz added accessibility accessibility - WCAG A Level A WCAG Accessibility Criteria labels May 1, 2018
@aphelionz aphelionz mentioned this issue May 1, 2018
Closed
5 tasks
@timroes
Copy link
Contributor

timroes commented May 7, 2018

I think this issue has the wrong screenshot?

@aphelionz
Copy link
Contributor Author

Yes, edited to remove the incorrect screenshot

snide added a commit to snide/eui that referenced this issue May 11, 2018
@snide
fixes elastic#746 applies proper label to select all checkboxes in table
a950bbd
@snide snide mentioned this issue May 11, 2018
Merged
snide added a commit that referenced this issue May 14, 2018
@snide
Fixes for accessibility tickets (#821)
a153c7a 
* pagination labeling fixes #735
* fixes #621 adds menubar roles to side nav
* fixes #734, adds more descriptive aria labeling for pagination
* fixes #729, apply aria-live to popovers
* fixes #723, provides screen reader notice for bottom bar appearance
* fix ownFocus needing to be true for non-context menu sitations. apply aria labels depending upon ownFocus state
* fixes #616 adds home page label
* fixes #687, documentation button labeling
* fixes #617 applies aria label to theme selector
* fixes #746 applies proper label to select all checkboxes in table
* clone element and id no longer needed for popover
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility - WCAG A Level A WCAG Accessibility Criteria accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes for accessibility tickets snide/eui
2 participants
@aphelionz @timroes