Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Palette names #58

Closed
cjcenizal opened this issue Oct 26, 2017 · 2 comments
Closed

Palette names #58

cjcenizal opened this issue Oct 26, 2017 · 2 comments

Comments

@cjcenizal
Copy link
Contributor

cjcenizal commented Oct 26, 2017

As noted in #54, we use "text" and "default" to refer to similar palette colors, which could be confusing for people.

Badge uses "default":

image

ButtonEmpty uses "text":

image

My suggestion is to just drop "text" and use "default" instead, since a prop of color="text" doesn't mean much to me, especially in the case of <KuiTextColor color="text">.

@cjcenizal
Copy link
Contributor Author

CC @snide

@chandlerprall
Copy link
Contributor

Closing this issue. The design team is doing housekeeping against our issues and closing items without much recent activity. Feel free to reopen if you still have issues or feel this is in error.

cee-chen pushed a commit that referenced this issue Aug 30, 2022
Allow for fullscreen routes in tabbed pages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants