Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EuiConfirmModal--option to set confirm button to red #520

Closed
gchaps opened this issue Mar 15, 2018 · 1 comment · Fixed by #546
Closed

EuiConfirmModal--option to set confirm button to red #520

gchaps opened this issue Mar 15, 2018 · 1 comment · Fixed by #546
Assignees
@cchaos

Comments

@gchaps
Copy link
Contributor

gchaps commented Mar 15, 2018

Confirmation modals are often used for delete actions. For this use case, it would be nice if we had an option to set the confirm button (Delete) to red.
@cchaos
Copy link
Contributor

cchaos commented Mar 16, 2018

I agree. I'm having a hard time deciding how to approach it though. The idea of "confirm" to me is an affirmative or non-destructive action so I'm not sure if we should add a prop to this or create a new component called EuiDestroyModal or whatever...

@cchaos cchaos self-assigned this Mar 20, 2018
cchaos pushed a commit to cchaos/eui that referenced this issue Mar 20, 2018
elastic#520 Added a type prop to EuiConfirmModal
4531c09 
Defaults to ‘confirm’ (positive/neutral), but can be ‘destroy’.
@cchaos cchaos mentioned this issue Mar 20, 2018
Merged
cchaos pushed a commit to cchaos/eui that referenced this issue Mar 20, 2018
elastic#520 Added a type prop to EuiConfirmModal
070d96c 
Defaults to ‘confirm’ (positive/neutral), but can be ‘destroy’.
cchaos pushed a commit to cchaos/eui that referenced this issue Mar 22, 2018
elastic#520 Added a type prop to EuiConfirmModal
99035a7 
Defaults to ‘confirm’ (positive/neutral), but can be ‘destroy’.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cchaos cchaos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Some random fixes cchaos/eui
2 participants
@cchaos @gchaps