Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiForm top-level error needs to be customizable #478

Closed
cjcenizal opened this issue Mar 7, 2018 · 6 comments · Fixed by #3585
Closed

EuiForm top-level error needs to be customizable #478

cjcenizal opened this issue Mar 7, 2018 · 6 comments · Fixed by #3585

Comments

@cjcenizal
Copy link
Contributor

cjcenizal commented Mar 7, 2018

The text we're currently using is hardcoded. It makes sense to offer a default, but the phrasing of "your form" sounds a little weird since it's not my form, it's Kibana's form. Maybe "Please address the errors below" would be more accurate. What do you think @gchaps ?

We should also allow the option of disabling the top-level error entirely.

image

@gchaps
Copy link
Contributor

gchaps commented Mar 7, 2018

@cjcenizal A couple of points:

  1. Do we need a message at the top of the form, especially for shorter forms? The message at the top is pretty close to the field that contains the error.

  2. If you do need this message, then you make a good point. The error is not with the Kibana form, but with the user input. But we don't want to say something that blames the user. Here are some choices--one's a little more whimsical.

Please address the errors highlighted below.
Something is not right. Errors are highlighted below.

  1. How about we make the error message under the Index pattern field a little shorter.

An index pattern cannot contain spaces or the character , /, ?, ", <, >, |.

@cjcenizal
Copy link
Contributor Author

Thanks @gchaps! Great points. I agree that this amount of feedback is overkill for a short form.

@cchaos
Copy link
Contributor

cchaos commented Mar 16, 2020

I think the main approach here is to:

  • Re-word the title of the callout from "Please address the errors in your form." to "Please address the errors highlighted below."
  • When EuiForm's isInvalid prop is true, also allow the alert/callout to be shown or not.

@gchaps
Copy link
Contributor

gchaps commented Mar 16, 2020

We are removing the spatial references "above", "below", "left", and "right" from the docs for accessibility reasons.

So I suggest this wording: "Please address the highlighted errors."

@shrey
Copy link
Contributor

shrey commented Jun 7, 2020

I'd like to work on this issue

@snide
Copy link
Contributor

snide commented Jun 8, 2020

@shrey go for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants