-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EuiForm top-level error needs to be customizable #478
Comments
@cjcenizal A couple of points:
Please address the errors highlighted below.
An index pattern cannot contain spaces or the character , /, ?, ", <, >, |. |
Thanks @gchaps! Great points. I agree that this amount of feedback is overkill for a short form. |
I think the main approach here is to:
|
We are removing the spatial references "above", "below", "left", and "right" from the docs for accessibility reasons. So I suggest this wording: "Please address the highlighted errors." |
I'd like to work on this issue |
@shrey go for it. |
The text we're currently using is hardcoded. It makes sense to offer a default, but the phrasing of "your form" sounds a little weird since it's not my form, it's Kibana's form. Maybe "Please address the errors below" would be more accurate. What do you think @gchaps ?
We should also allow the option of disabling the top-level error entirely.
The text was updated successfully, but these errors were encountered: