Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid] [EuiLoading] While data is being fetched for a table, what should I display? #4329

Closed
j-m opened this issue Dec 2, 2020 · 1 comment

Comments

@j-m
Copy link
Contributor

j-m commented Dec 2, 2020

I know there's EuiLoadingSpinner and EuiLoadingContent, but neither feel quite right to me; they both feel too small, especially if the page is designed for a table with 100 rows.

Could we introduce a component called EuiLoadingBlock that takes width and height props? I feel this would also be good for components like images or other custom components that have fixed (or predictable) dimensions. Ideally, the props would assume px but also allow percentage or relative units. I think this also fills a gap not covered by EuiLoadingContent as, by design and rightly so, it does not accept more than 10 lines.

If this isn't the EUI way then fair enough, but I'd be interested in hearing other people's designs

Also, just my 2 pence, EuiLoadingContent should probably be renamed to EuiLoadingText

@j-m
Copy link
Contributor Author

j-m commented Dec 2, 2020

Whoops, forgot to search for existing issues first, sorry
#4181
#3474

@j-m j-m closed this as completed Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant