Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discuss] Skeleton component and usage #3474

Closed
snide opened this issue May 13, 2020 · 8 comments
Closed

[Discuss] Skeleton component and usage #3474

snide opened this issue May 13, 2020 · 8 comments

Comments

@snide
Copy link
Contributor

snide commented May 13, 2020

@bevacqua reminded us that folks are using <EuiLoadingContent lines={3} /> quite a bit downstream. We've also seen some usage in the SIEM apps that @andrew-goldstein and @XavierM put together. We had a discussion as a team about how to handle these types of loading states and came away with the following discussion points:

We need more skeleton primitives for off the cuff usage

To "fake" components we probably need skeleton solutions to the following:

  • Images
  • Avatars
  • Text of various sizes
  • "Blocks"

Long term, it might be nice to build skeleton modes into the components directly

We rambled a little bit about whether EUI components should actually have a skeleton boolean prop that would just automatically fake content as needed.

image

@myasonik
Copy link
Contributor

Haven't looked too into this, but wanted to drop this somewhere it wouldn't be forgotten about:

An accessible skeleton component demo

@cchaos
Copy link
Contributor

cchaos commented Sep 18, 2020

Padding this with a link to an old discussion of using this in tables as well. #476

@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@snide
Copy link
Contributor Author

snide commented Mar 18, 2021

Added this to a long term goal.

@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@AndreaDellaValle
Copy link
Contributor

AndreaDellaValle commented Oct 30, 2022

Hello folks 👋

I'm enjoying using EUI to build interfaces, and I want to thank you guys for all this precious work 🙏

Speaking about the need for Skeleton primitives, I totally agree, and at the moment I'm keeping up only by heavily hacking the EuiLoadingContent component. But this is not so maintainable for the long term.

So as per CONTRIBUTING guidelines, I'm posting this to mark my intent to work on this new EuiSkeleton component proposal, and I'll come up with a draft PR in the next weeks to better discuss.

NOTE: I'm comparing skeleton components of other design systems and trying to end up with a proposal that sticks with the EUI structure as much as possible, but of course, this will overlap with the EuiLoadingContent component so later we can also discuss how to handle this).

See you soon

@AndreaDellaValle
Copy link
Contributor

PR link #6502

@cee-chen
Copy link
Contributor

Closed by #6558

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants