Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<EuiFlexGroup> alignItems='baseline' support #423

Closed
bevacqua opened this issue Feb 16, 2018 · 3 comments · Fixed by #546
Closed

<EuiFlexGroup> alignItems='baseline' support #423

bevacqua opened this issue Feb 16, 2018 · 3 comments · Fixed by #546
Assignees
Labels

Comments

@bevacqua
Copy link
Contributor

For text and images combinations, baseline makes more sense than flex-end, but it's not supported by this component yet.

@bevacqua bevacqua added the bug label Feb 16, 2018
@cchaos
Copy link
Contributor

cchaos commented Feb 16, 2018

There are actually a lot of values for the typical align-items css property that aren't available in EuiFlexGroup.

CSS values:

/* Basic keywords */ 
align-items: normal; 
align-items: stretch; 

/* Positional alignment */ 
align-items: center; /* Pack items around the center */ 
align-items: start; /* Pack items from the start */ 
align-items: end; /* Pack items from the end */ 
align-items: flex-start; /* Pack flex items from the start */ 
align-items: flex-end; /* Pack flex items from the end */ 
align-items: self-start; 
align-items: self-end; 
align-items: left; /* Pack items from the left */ 
align-items: right; /* Pack items from the right */ 

/* Baseline alignment */
align-items: baseline; 
align-items: first baseline; 
align-items: last baseline; /* Overflow alignment (for positional alignment only) */ 
align-items: safe center; 
align-items: unsafe center; 

/* Global values */ 
align-items: inherit; 
align-items: initial; 
align-items: unset;

Supported:

  stretch: null,
  flexStart: 'euiFlexGroup--alignItemsFlexStart',
  flexEnd: 'euiFlexGroup--alignItemsFlexEnd',
  center: 'euiFlexGroup--alignItemsCenter',

@bevacqua
Copy link
Contributor Author

bevacqua commented Feb 17, 2018 via email

@cchaos
Copy link
Contributor

cchaos commented Mar 20, 2018

Based on reading through some docs, the only safe-to-implement ones (that we don't have) are:

align-items: normal; 
align-items: baseline; 

I can add these.

@cchaos cchaos self-assigned this Mar 20, 2018
cchaos pushed a commit to cchaos/eui that referenced this issue Mar 20, 2018
…tems` prop

__’normal’ doesn’t do anything__
cchaos pushed a commit to cchaos/eui that referenced this issue Mar 20, 2018
…tems` prop

__’normal’ doesn’t do anything__
cchaos pushed a commit to cchaos/eui that referenced this issue Mar 22, 2018
…tems` prop

__’normal’ doesn’t do anything__
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants