New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark theme modals have low-contrast against the background #334

Closed

cjcenizal opened this issue Jan 23, 2018 · 0 comments · Fixed by #546

Assignees

Contributor

cjcenizal commented Jan 23, 2018

This is because the OverlayMask defaults to the empty color. I think in dark mode we need to use a semi-transparent gray value instead:

cchaos self-assigned this

cchaos pushed a commit to cchaos/eui that referenced this issue


          Fixes elastic#334 - Lightening overlay color in dark theme

19774a9

cchaos mentioned this issue

Some random fixes #546

Merged

cchaos pushed a commit to cchaos/eui that referenced this issue


          Fixes elastic#334 - Lightening overlay color in dark theme

427bf9f

cchaos pushed a commit to cchaos/eui that referenced this issue


          Fixes elastic#334 - Lightening overlay color in dark theme

32e6bfe

cchaos closed this as completed in #546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment