-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiBasicTable] Actions popover should announce it is a popup #1546
Comments
Is this the same as/would be solve by #731? |
@cchaos this does sound similar to #731. If you compare the screenreader behavior for |
👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
Happy for this to be closed if this requirement can be added specifically to one of #731, #3889, and #4040 as suggested in #1546 (comment). |
👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
See #1546 (comment) - happy for this to be closed if this requirement can be added to one of #731, #3889, or #4040 |
What OS and screen reader are you using @peteharverson? I'm unable to fully reproduce this. For me MacOS + VO does announce "You are in a dialogue", albeit very briefly since focus is immediately hijacked to the first button in the popover (see also #5683). I don't get "Exiting table" from VO at all. @1Copenut, any thoughts on this? |
@constancecchen I'm on Windows and use the Chrome Screen Reader extension. The behavior seems to have changed since I last tested this - when the actions popover in an EuiTable opens I now get 'Entering dialog', which I don't remembering getting at the time I raised this issue. Often I don't hear the full 'Entering dialog' message as the focus is immediately transferred to the first action item. I'm happy for this to be closed if you think we are now meeting the current requirements. |
Awesome, thanks a million Pete. Sounds like we improved our popover SR behavior at some point. I'll go ahead and close this since at least the dialog state is announced, although I'm +1 with you on this:
I think we should address this in #5683 as another more holistic EuiPopover screen reader improvement. Please feel free to chime in on that issue, we could always use more voices with folks on various OS's and screen readers! ❤️ |
The screen reader for a popup menu opened from actions cell in an EUI table should read "You are in a popup, press escape" like other popups. Currently it only reads "Exiting table".
Possibly related to #503.
Relevant WCAG Criteria: 3.2.3 Consistent Navigation
The text was updated successfully, but these errors were encountered: