Fixed prop not displaying for EuiExpression (#3929)

elastic · Aug 17, 2020 · ec671de · ec671de
1 parent bc6ff6e
commit ec671de
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/components/expression/expression.tsx b/src/components/expression/expression.tsx
@@ -22,6 +22,7 @@ import React, {
   HTMLAttributes,
   MouseEventHandler,
   ReactNode,
+  FunctionComponent,
 } from 'react';
 import classNames from 'classnames';
 import { CommonProps, keysOf, ExclusiveUnion } from '../common';
@@ -99,13 +100,14 @@ export type EuiExpressionProps = CommonProps & {
 };
 
 type Buttonlike = EuiExpressionProps &
-  ButtonHTMLAttributes<HTMLButtonElement> & {
+  Omit<ButtonHTMLAttributes<HTMLButtonElement>, 'value'> & {
     onClick: MouseEventHandler<HTMLButtonElement>;
   };
 
-type Spanlike = EuiExpressionProps & HTMLAttributes<HTMLSpanElement>;
+type Spanlike = EuiExpressionProps &
+  Omit<HTMLAttributes<HTMLSpanElement>, 'value'>;
 
-export const EuiExpression: React.FunctionComponent<ExclusiveUnion<
+export const EuiExpression: FunctionComponent<ExclusiveUnion<
   Buttonlike,
   Spanlike
 >> = ({